fix(core): don't create PDB files when debug=false (upstream mkaring#532)

Cherry-pick of mkaring#532 changes:
- Skip PDB file creation in Debug phase when project debug flag is false
- Remove hardening instruction count limit (>150) that restricted method inlining
- Pin decrypted assembly bytes with GCHandle to prevent GC relocation during load

Author: RandomCrocodile

Confuser.Core/ConfuserEngine.cs

@@ -421,6 +421,8 @@ static void WriteModule(ConfuserContext context) {
 
 		static void Debug(ConfuserContext context) {
 			context.Logger.Info("Finalizing...");
+			if(!context.Project.Debug)
+				return;
 			for (int i = 0; i < context.OutputModules.Count; i++) {
 				if (context.OutputSymbols[i] == null)
 					continue;

Confuser.Protections/HardeningPhase.cs

@@ -48,9 +48,6 @@ private static void HardenMethod(ConfuserContext context, ModuleDef module) {
 				// Resource protection needs to rewrite the method during the write phase. Not compatible!
 				if (protection.FullId.Equals(ResourceProtection._FullId)) continue;
 
-				// Skip large methods to avoid aggregating suspicious patterns in .cctor
-				if (targetMethod.HasBody && targetMethod.Body.Instructions.Count > 150) continue;
-
 				cctor.Body.MergeCall(instructions[i]);
 				targetMethod.DeclaringType.Methods.Remove(targetMethod);
 			}

Confuser.Runtime/Compressor.Compat.cs

@@ -1,13 +1,14 @@
 using System;
 using System.IO;
 using System.Reflection;
+using System.Runtime.InteropServices;
 using System.Text;
 
 namespace Confuser.Runtime {
 	internal static class CompressorCompat {
 		static byte[] key;
 
-		static byte[] Decrypt(uint[] data, uint seed) {
+		static GCHandle Decrypt(uint[] data, uint seed) {
 			var w = new uint[0x10];
 			var k = new uint[0x10];
 			ulong s = seed;
@@ -34,23 +35,26 @@ static byte[] Decrypt(uint[] data, uint seed) {
 			byte[] j = Lzma.Decompress(b);
 			Array.Clear(b, 0, b.Length);
 
+			GCHandle g = GCHandle.Alloc(j, GCHandleType.Pinned);
 			var z = (uint)(s % 0x8a5cb7);
 			for (int i = 0; i < j.Length; i++) {
 				j[i] ^= (byte)s;
 				if ((i & 0xff) == 0)
 					s = (s * s) % 0x8a5cb7;
 			}
-			return j;
+			return g;
 		}
 
 		[STAThread]
 		static int Main(string[] args) {
 			var l = (uint)Mutation.KeyI0;
 			uint[] q = Mutation.Placeholder(new uint[Mutation.KeyI0]);
 
-			byte[] b = Decrypt(q, (uint)Mutation.KeyI1);
+			GCHandle h = Decrypt(q, (uint)Mutation.KeyI1);
+			var b = (byte[])h.Target;
 			Assembly a = Assembly.Load(b);
 			Array.Clear(b, 0, b.Length);
+			h.Free();
 			Array.Clear(q, 0, q.Length);
 
 			var m = typeof(CompressorCompat).Module;
@@ -89,9 +93,12 @@ static Assembly Resolve(object sender, ResolveEventArgs e) {
 				uint s = 0x6fff61;
 				foreach (byte c in b)
 					s = s * 0x5e3f1f + c;
-				byte[] f = Decrypt(d, s);
+				GCHandle h = Decrypt(d, s);
+
+				var f = (byte[])h.Target;
 				Assembly a = Assembly.Load(f);
 				Array.Clear(f, 0, f.Length);
+				h.Free();
 				Array.Clear(d, 0, d.Length);
 
 				return a;

Confuser.Runtime/Compressor.cs

@@ -1,13 +1,14 @@
 using System;
 using System.IO;
 using System.Reflection;
+using System.Runtime.InteropServices;
 using System.Text;
 
 namespace Confuser.Runtime {
 	internal static class Compressor {
 		static byte[] key;
 
-		static byte[] Decrypt(uint[] data, uint seed) {
+		static GCHandle Decrypt(uint[] data, uint seed) {
 			var w = new uint[0x10];
 			var k = new uint[0x10];
 			ulong s = seed;
@@ -34,13 +35,14 @@ static byte[] Decrypt(uint[] data, uint seed) {
 			byte[] j = Lzma.Decompress(b);
 			Array.Clear(b, 0, b.Length);
 
+			GCHandle g = GCHandle.Alloc(j, GCHandleType.Pinned);
 			var z = (uint)(s % 0x8a5cb7);
 			for (int i = 0; i < j.Length; i++) {
 				j[i] ^= (byte)s;
 				if ((i & 0xff) == 0)
 					s = (s * s) % 0x8a5cb7;
 			}
-			return j;
+			return g;
 		}
 
 		[STAThread]
@@ -50,10 +52,12 @@ static int Main(string[] args) {
 
 			Assembly a = Assembly.GetExecutingAssembly();
 			Module n = a.ManifestModule;
-			byte[] b = Decrypt(q, (uint)Mutation.KeyI1);
+			GCHandle h = Decrypt(q, (uint)Mutation.KeyI1);
+			var b = (byte[])h.Target;
 			Module m = a.LoadModule("koi", b);
 
 			Array.Clear(b, 0, b.Length);
+			h.Free();
 			Array.Clear(q, 0, q.Length);
 
 			key = n.ResolveSignature(Mutation.KeyI2);
@@ -94,9 +98,12 @@ static Assembly Resolve(object sender, ResolveEventArgs e) {
 				uint s = 0x6fff61;
 				foreach (byte c in b)
 					s = s * 0x5e3f1f + c;
-				byte[] f = Decrypt(d, s);
+				GCHandle h = Decrypt(d, s);
+
+				var f = (byte[])h.Target;
 				Assembly a = Assembly.Load(f);
 				Array.Clear(f, 0, f.Length);
+				h.Free();
 				Array.Clear(d, 0, d.Length);
 
 				return a;