fix: correctly detect dumb terminal on Windows - #818
Merged
Merged
Conversation
djc
reviewed
Jul 1, 2026
Member
|
(And please add a version bump commit here, too.) |
ugur-eren
force-pushed
the
fix/is-dumb-check-windows
branch
from
July 1, 2026 13:33
9005e89 to
c6d987e
Compare
djc
approved these changes
Jul 1, 2026
Member
|
Published 0.18.6, thanks! |
sunshowers
added a commit
to nextest-rs/nextest
that referenced
this pull request
Jul 7, 2026
Need to pull in console-rs/indicatif#818.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect dumb-terminal detection on Windows
The current check for whether to hide the progress bar relies on reading the TERM environment variable directly:
This treats an unset
TERMas "dumb" and hides the progress bar.On Windows,
TERMis typically not set at all, even in perfectly capable terminals (Windows Terminal, PowerShell, cmd.exe, etc.), so this logic incorrectly hides progress bars on Windows in cases where they should be shown.Behavior
Unset
TERMenvironment variable is now treated as "not dumb" on Windows.Note
This depends on
is_dumb()being exposed from the console crate. See console-rs/console#290 for the corresponding change adding a publicis_dumb()function.is_dumbpublic function console#290