chore(controller): stop reporting spurious VolumeClaimTemplates changes on every reconcile

[miledxz]

Problem

Since v1.6.0 (#519) every Dragonfly instance with a persistentVolumeClaimSpec logs

VolumeClaimTemplates change detected but cannot be applied to an existing StatefulSet; ...

and emits a Warning ImmutableField event on each reconcile, including fresh installs and operator restarts, even though the PVC spec was never changed.

reconcileResources compared stsDesired.Spec.VolumeClaimTemplates with the live templates using reflect.DeepEqual. The API server adds fields the operator never sets, so the two sides are never byte-equal:

- apiVersion: v1                 # added
  kind: PersistentVolumeClaim    # added
  spec:
    volumeMode: Filesystem       # defaulted
  status:
    phase: Pending               # added

Reproduced and verified on a kind cluster (Kubernetes v1.34)

[Copilot]

🟡 Changes recommended

Add the requested comparison tests and normalize the dataSource/dataSourceRef pair.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR updates StatefulSet PVC template comparison to avoid spurious immutable-field warnings caused by Kubernetes-populated defaults.

Changes:

• Adds normalized PVC template equality checks.
• Normalizes the default volumeMode before comparison.

File summaries

File	Summary
internal/controller/dragonfly_instance.go	Implementation reviewed; tests are needed for normalized defaults and real changes, and dataSource/dataSourceRef synchronization must also be normalized.

Review details

Suppressed comments (1)

internal/controller/dragonfly_instance.go:786

• This still compares the full PVC spec after normalizing only volumeMode. Kubernetes also synchronizes dataSource and dataSourceRef when one is supplied (the CRD exposes both), so a template created from a spec containing only one of them can come back with both and trigger this warning on every reconcile. Normalize that pair (or apply the Kubernetes PVC defaults to both operands) before comparing.

		if !equality.Semantic.DeepEqual(defaultedPVCSpec(d.Spec), defaultedPVCSpec(e.Spec)) {
			return false

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.