feat(generator): emit resumable upload client surface by whowes · Pull Request #14319 · googleapis/google-cloud-java

whowes · 2026-09-09T06:33:27Z

Generates the public client surface and base stub contracts for resumable upload RPCs, providing both an asynchronous ResumableUploadCallable and a synchronous InputStream method.

Test composers are updated with placeholder @Ignored tests to reflect that meaningful testing is only exercised via integration tests. This is due to insufficient mock capabilities, which may make sense to augment for resumable uploads in the future.

Sample code generation for resumable uploads is disabled; this also probably makes sense to add in the future.

blakeli0 · 2026-09-16T03:42:07Z

We don't need to generate unit tests for resumable uploads.

Ack - they are no longer generated (previously had been @Ignored test cases). If a service contains only resumable upload RPCs, test class generation is now suppressed to avoid emitting empty test classes with no runnable tests.

blakeli0 · 2026-09-18T21:51:38Z

+   * @param payload The payload data stream to upload.
+   * @throws com.google.api.gax.rpc.ApiException if the remote call fails
+   */
+  public final UploadMediaResponse uploadMedia(UploadMediaRequest request, InputStream payload) {


Can we expose ResumableUploadCallSettings as a nullable argument? It can be up to the customer to decide whether they want to pass null or not.

snippet-bot · 2026-09-19T00:11:03Z

Here is the summary of changes.

You are about to add 3 region tags.

sdk-platform-java/gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/resumableuploadserviceclient/SyncCreateSetCredentialsProvider.golden:19, tag goldensample_generated_ResumableUploadService_Create_SetCredentialsProvider_sync
sdk-platform-java/gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/resumableuploadserviceclient/SyncCreateSetEndpoint.golden:19, tag goldensample_generated_ResumableUploadService_Create_SetEndpoint_sync
sdk-platform-java/gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/samples/resumableuploadserviceclient/SyncEmtpy.golden:19, tag goldensample_generated_ResumableUploadService_Emtpy_sync

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

blakeli0 · 2026-09-19T00:15:58Z

Are the changes in this class and ServiceClientMethodSampleComposerTest below necessary?

The changes were necessary with a previous attempt to suppress sample generation for resumable uploads, but that approach had an unnecessarily large blast radius (signature changes in the composer that had better alternatives). Reverted now.

…mable upload RPCs - In AbstractServiceClientClassComposer: emit public ResumableUploadCallable<RequestT, ResponseT> [method]Callable() delegating to stub - In AbstractServiceClientClassComposer: emit synchronous convenience method [method](RequestT request, InputStream payload) calling ApiExceptions.callAndTranslateApiException - Suppress method variants (flattened methods) for resumable upload RPCs - In ServiceClientCommentComposer: emit Javadoc call context override warning on both callable method and synchronous convenience method - Cover the generated client and its samples with ResumableUploadServiceClient.golden and the resumableuploadserviceclient sample goldens

sonarqubecloud · 2026-09-19T00:53:54Z

Quality Gate passed for 'gapic-generator-java-root'

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-09-19T00:55:05Z

Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

whowes added this pull request to stack #14327 September 9, 2026 06:35

This comment was marked as outdated.

Sign in to view

whowes force-pushed the whowes/generator-client-codegen branch from a07c67a to e0d1fe6 Compare September 9, 2026 15:50

whowes force-pushed the whowes/generator-client-codegen branch from e0d1fe6 to c202895 Compare September 9, 2026 20:16

whowes removed this pull request from stack #14327 September 9, 2026 23:45

whowes added this pull request to stack #14343 September 9, 2026 23:47

whowes force-pushed the whowes/generator-client-codegen branch 2 times, most recently from 39fdadf to 775a413 Compare September 10, 2026 00:19

whowes force-pushed the whowes/generator-client-codegen branch from 775a413 to 3c5beaf Compare September 10, 2026 01:15

whowes force-pushed the whowes/generator-client-codegen branch from 3c5beaf to 9297723 Compare September 10, 2026 06:05

whowes force-pushed the whowes/generator-client-codegen branch from 9297723 to 5da1a23 Compare September 11, 2026 17:23

whowes removed this pull request from stack #14343 September 11, 2026 17:25

whowes added this pull request to stack #14363 September 11, 2026 17:25

whowes force-pushed the whowes/generator-client-codegen branch from 5da1a23 to a885ba0 Compare September 11, 2026 20:00

whowes force-pushed the whowes/generator-client-codegen branch from a885ba0 to 9215157 Compare September 11, 2026 21:13

whowes force-pushed the whowes/generator-client-codegen branch from 9215157 to 25824bd Compare September 11, 2026 21:39

whowes force-pushed the whowes/generator-client-codegen branch from 25824bd to 18c348f Compare September 14, 2026 21:34

whowes removed this pull request from stack #14363 September 14, 2026 22:18

whowes added this pull request to stack #14381 September 14, 2026 22:19

whowes removed this pull request from stack #14381 September 14, 2026 23:13

whowes force-pushed the whowes/generator-client-codegen branch from 6e17945 to 2b84d27 Compare September 17, 2026 18:11

whowes force-pushed the whowes/generator-client-codegen branch from 2b84d27 to b82fa28 Compare September 17, 2026 22:55

whowes force-pushed the whowes/generator-client-codegen branch from b82fa28 to 863c40e Compare September 18, 2026 04:30

whowes force-pushed the whowes/generator-client-codegen branch from 863c40e to cb86a89 Compare September 18, 2026 15:03

whowes force-pushed the whowes/generator-client-codegen branch from cb86a89 to 08820ce Compare September 18, 2026 18:18

blakeli0 reviewed Sep 18, 2026

View reviewed changes

whowes force-pushed the whowes/generator-client-codegen branch from 08820ce to a1b682c Compare September 18, 2026 22:20

whowes force-pushed the whowes/generator-client-codegen branch from a1b682c to 904b2d4 Compare September 18, 2026 23:08

whowes removed this pull request from stack #14390 September 18, 2026 23:50

whowes force-pushed the whowes/generator-client-codegen branch from 904b2d4 to 1b9002f Compare September 19, 2026 00:07

whowes marked this pull request as ready for review September 19, 2026 00:10

whowes requested review from a team as code owners September 19, 2026 00:11

whowes requested a review from blakeli0 September 19, 2026 00:11

whowes added this pull request to stack #14442 September 19, 2026 00:11

blakeli0 reviewed Sep 19, 2026

View reviewed changes

whowes force-pushed the whowes/generator-client-codegen branch from 1b9002f to 47718ae Compare September 19, 2026 00:36

whowes force-pushed the whowes/generator-client-codegen branch from 47718ae to 0bc2a0e Compare September 19, 2026 00:46

Navigation Menu

feat(generator): emit resumable upload client surface - #14319

feat(generator): emit resumable upload client surface#14319
whowes wants to merge 1 commit into
whowes/generator-transport-stub-delegationfrom
whowes/generator-client-codegen

whowes commented Sep 9, 2026 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

blakeli0 Sep 16, 2026

Uh oh!

whowes Sep 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

blakeli0 Sep 18, 2026

Uh oh!

whowes Sep 18, 2026

Uh oh!

snippet-bot Bot commented Sep 19, 2026 •

edited

Loading

Uh oh!

blakeli0 Sep 19, 2026

Uh oh!

whowes Sep 19, 2026

Uh oh!

sonarqubecloud Bot commented Sep 19, 2026

Uh oh!

sonarqubecloud Bot commented Sep 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

whowes commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

blakeli0 Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

whowes Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

blakeli0 Sep 18, 2026

Choose a reason for hiding this comment

Uh oh!

whowes Sep 18, 2026

Choose a reason for hiding this comment

Uh oh!

snippet-bot Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blakeli0 Sep 19, 2026

Choose a reason for hiding this comment

Uh oh!

whowes Sep 19, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Sep 19, 2026

Quality Gate passed for 'gapic-generator-java-root'

Uh oh!

sonarqubecloud Bot commented Sep 19, 2026

Quality Gate passed for 'gapic-generator-java-root'

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

whowes commented Sep 9, 2026 •

edited

Loading

whowes Sep 18, 2026 •

edited

Loading

snippet-bot Bot commented Sep 19, 2026 •

edited

Loading