Skip to content

Allow unlimited route-level cold-start pending requests in HTTP add-on #1801

Description

@coderabbitai

Summary

InterceptorRoute.spec.coldStart.maxPendingRequests rejects 0 because its CRD validation requires a value of at least 1.

The HTTP add-on configuration defines 0 as unlimited. A route-level value overrides the global coldStart.maxPendingRequests setting. A user therefore cannot set unlimited pending requests for one route when the global setting is finite.

Required change

Update the HTTP add-on source CRD and the associated API validation so that spec.coldStart.maxPendingRequests: 0 is accepted as the unlimited route-level override. Keep the existing behavior for positive limits.

Update the route-level field documentation to state that 0 means unlimited.

Affected area

  • The InterceptorRoute CRD source and generated CRD manifests in this repository.
  • The InterceptorRoute API types and validation, if applicable.
  • Cold-start request handling that interprets maxPendingRequests.

The Helm chart repository consumes the CRD generated by this repository. Do not make the chart template the primary fix location.

Acceptance criteria

  • spec.coldStart.maxPendingRequests: 0 passes CRD validation.
  • 0 means unlimited pending requests for that route.
  • Positive values remain accepted and retain their current limit behavior.
  • Route-level configuration continues to override the global setting.
  • Tests cover 0, a positive value, and the interaction with a finite global limit.
  • Generated CRD artifacts are updated when this repository maintains them.

Backlinks

Requested by: @linkvt

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions