Pre release - #79
Merged
Merged
Conversation
…utput (#78) Before: ci.yml and test.yml each did a full MSBuild restore + build (~4 min each) After: ci.yml builds + uploads artifacts, test.yml downloads and runs tests only Changes: - ci.yml: add build-output artifact upload (1-day retention) - ci.yml: add paths-ignore (skip on docs-only changes) - ci.yml: add concurrency (cancel in-progress on new push) - test.yml: trigger on workflow_run (waits for CI completion) - test.yml: download build-output instead of building - test.yml: no more restore/build steps - format.yml: only trigger when .cs/.vb/.editorconfig files change Saves ~4 min of Windows runner time per push by not building twice. All 3 workflows remain separate with their own status checks. Co-authored-by: RandomCrocodile <mawi@polosab.com>
CodeQL was still on windows-2022 (MSBuild 17) which can't resolve .NET 10 SDK from global.json. Also removed obsolete .NET 4.6.1 targeting pack install (net48 doesn't need it) and bumped checkout to v5.
- Issue template config: point discussions to our repo, add Ideas + General links
- CODEOWNERS: mkaring → mcpolo99
- FUNDING.yml: mkaring → mcpolo99
- MSBuild.Tasks PackageProjectUrl: point to our repo
- Test [Trait("Issue")] attributes kept as upstream attribution (historical)
…ents workflow_run doesn't associate with PRs reliably — test results and coverage comments were not posted on PR #79. Reverted to direct push/pull_request triggers with its own build step. Still optimized with: - paths-ignore (skip on docs-only changes) - concurrency (cancel in-progress on new push) - NuGet cache (shared cache key with ci.yml) - Removed build-output artifact from ci.yml (no longer needed)
Test Results
Cross-Framework Details
SummarySummary
CoverageConfuser.CLI - 53.3%
Confuser.Core - 25.7%
Confuser.DynCipher - 0.2%
Confuser.Protections - 4.9%
Confuser.Renamer - 42%
Confuser.UnitTest - 0%
|
mcpolo99
added a commit
that referenced
this pull request
Jun 11, 2026
* feat: retarget ConfuserEx from .NET Framework 4.6.1 to .NET 10 (#71) * perf(ci): eliminate duplicate build — test workflow reuses CI build output (#78) Before: ci.yml and test.yml each did a full MSBuild restore + build (~4 min each) After: ci.yml builds + uploads artifacts, test.yml downloads and runs tests only Changes: - ci.yml: add build-output artifact upload (1-day retention) - ci.yml: add paths-ignore (skip on docs-only changes) - ci.yml: add concurrency (cancel in-progress on new push) - test.yml: trigger on workflow_run (waits for CI completion) - test.yml: download build-output instead of building - test.yml: no more restore/build steps - format.yml: only trigger when .cs/.vb/.editorconfig files change Saves ~4 min of Windows runner time per push by not building twice. All 3 workflows remain separate with their own status checks. Co-authored-by: RandomCrocodile <mawi@polosab.com> * fix(ci): update CodeQL to windows-2025 for MSBuild 18 / .NET 10 support CodeQL was still on windows-2022 (MSBuild 17) which can't resolve .NET 10 SDK from global.json. Also removed obsolete .NET 4.6.1 targeting pack install (net48 doesn't need it) and bumped checkout to v5. * chore: update repo references from mkaring to mcpolo99/ConfuserExx - Issue template config: point discussions to our repo, add Ideas + General links - CODEOWNERS: mkaring → mcpolo99 - FUNDING.yml: mkaring → mcpolo99 - MSBuild.Tasks PackageProjectUrl: point to our repo - Test [Trait("Issue")] attributes kept as upstream attribution (historical) * fix(ci): revert test workflow to direct triggers for reliable PR comments workflow_run doesn't associate with PRs reliably — test results and coverage comments were not posted on PR #79. Reverted to direct push/pull_request triggers with its own build step. Still optimized with: - paths-ignore (skip on docs-only changes) - concurrency (cancel in-progress on new push) - NuGet cache (shared cache key with ci.yml) - Removed build-output artifact from ci.yml (no longer needed) * chore: adopt GitHub branch conventions — master→main, pre-release→develop (#82) * chore: rename master→main, pre-release→develop, adopt GitHub branch conventions Branch renames: - master → main (default branch) - pre-release → develop (integration branch) All references updated: - ci.yml: triggers, release jobs, dev-release job (was pre-release) - test.yml, format.yml, codeql-analysis.yml: branch triggers - dependabot.yml: target branch - README.md: contributing section, CI badge - CONTRIBUTING.md: branch naming convention, PR target New branch naming convention (documented in CONTRIBUTING.md): - Issue-linked: {number}-{slug} via gh issue develop - Feature: feature/{description} - Chore: chore/{description} - Docs: docs/{description} - Hotfix: hotfix/{description} (from main) - Experiment: experiment/{description} * feat(ci): lightweight lint on push, full CI on PR only (#81) New workflow layout: - lint.yml (NEW): every push + PR — format + style + Roslyn analyzers without building. Posts results to PR comment or issue comment (parses issue number from branch name). ~2 min. - ci.yml: PR + main/develop push only — full build + package - test.yml: PR only — full build + test + coverage - codeql: weekly (Mon 3am, skips if no commits) + manual trigger - format.yml: DELETED — replaced by lint.yml Cost per event: - Feature branch push: ~2 min (was ~9 min) — 77% reduction - PR: ~11 min (lint + ci + test, unchanged) - Merge to main: ~5 min (ci only) - CodeQL: weekly conditional, not on every push/PR --------- Co-authored-by: RandomCrocodile <mawi@polosab.com> * docs: update commit convention to match branch naming — full words, no scopes --------- Co-authored-by: RandomCrocodile <mawi@polosab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.