Skip to content

metal/phong material widget fix preview widget resizing - #67446

Open
ptitjano wants to merge 2 commits into
qgis:masterfrom
ptitjano:3d-widget-preview-resize-fix
Open

ptitjano wants to merge 2 commits into
qgis:masterfrom
ptitjano:3d-widget-preview-resize-fix

Conversation

@ptitjano

Copy link
Copy Markdown
Collaborator

Description

#67191 fixed some horizontal alignement of those widgets however this also introduced a regression. This PR fixes the regression. See below

current master - regression

master.mp4

this PR - fix - same behavior as 4.2

fxied.mp4

AI tool usage

No AI tool used

ef61eb9 fixed the widget
alignement. However, this broke preview correct resizing when the
preview is visible. Fix it by only activating column stretch when the
preview is hidden.
01f2270 fixed the widget
alignement. However, this broke preview correct resizing when the
preview is visible. Fix it by only activating column stretch when the
preview is hidden.
@ptitjano ptitjano self-assigned this Sep 15, 2026
@ptitjano ptitjano added the Regression Something which used to work, but doesn't anymore label Sep 15, 2026
@github-actions github-actions Bot added this to the 4.4.0 milestone Sep 15, 2026
@github-actions github-actions Bot added GUI/UX Related to QGIS application GUI or User Experience 3D Relates to QGIS' 3D engine or rendering labels Sep 15, 2026
@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
To execute locally, unzip the downloaded zip file and run bin\qgis-bin.exe in the extracted directory.
You might be prompted by Windows Defender click "Run anyway"
(Built from commit 8530563)

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This app is not notarized, run sudo xattr -d com.apple.quarantine /Applications/QGIS*.app to avoid the warning
(Built from commit 8530563)

@ptitjano

Copy link
Copy Markdown
Collaborator Author

unrelated unit test failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3D Relates to QGIS' 3D engine or rendering GUI/UX Related to QGIS application GUI or User Experience Regression Something which used to work, but doesn't anymore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants