[#19105] Pick heading levels for structure, not size - #19114
Open
codyrancher wants to merge 1 commit into
Open
codyrancher wants to merge 1 commit into
codyrancher wants to merge 1 commit into
Conversation
codyrancher
force-pushed
the
issue-19105
branch
2 times, most recently
from
September 11, 2026 22:11
e6390ed to
af381ea
Compare
Contributor
|
🔄 Auto-Retry Failed Run The Tests workflow failed for the commits below and has been automatically retried.
|
codyrancher
force-pushed
the
issue-19105
branch
from
September 11, 2026 22:52
af381ea to
70557ef
Compare
codyrancher
marked this pull request as ready for review
September 11, 2026 23:31
Member
|
Approved - grade A- No test run - decided on the review grade alone. Suggestions (1)
Nits (2)
|
codyrancher
force-pushed
the
issue-19105
branch
2 times, most recently
from
September 12, 2026 00:53
83b66bc to
e73439f
Compare
codyrancher
force-pushed
the
issue-19105
branch
2 times, most recently
from
September 14, 2026 22:35
13e9d05 to
0049fab
Compare
Adds RcHeading, a section heading whose look comes from a size prop rather than from its level, and uses it for the headings behind the heading-order entries in the a11y baseline. Fixes rancher#19105
codyrancher
force-pushed
the
issue-19105
branch
from
September 14, 2026 23:43
0049fab to
38d2a33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19105
Occurred changes and/or fixed issues
RcHeading: renders anh2with a look set by:size="1"to:size="6".heading-orderbaseline entries use it, one level below the page title at the same size.baseline.jsonloses those 15 entries. The Move namespace dialog, a newerheading-orderviolation on master, is converted too.Technical notes summary
h2: every heading it replaces is a page section or a dialog title. Size is in its scoped CSS, so globalh1-h6styles and other headings are untouched.RcItemCardrenderingh2made six otherh4s skip a level (flagged by the a11y run), so they changed too:IngressConfigurationand the five Extensions page dialogs.Areas or cases that should be tested
Nothing to install. axe reports no
heading-orderviolation, and headings look unchanged.Areas which could experience regressions
KeyValue,RcItemCardandCruResourcetitles now render ash2everywhere those components are used..title h5rule toCruResource's scoped styles.Screenshot/Video
Before - level badges: Preferences goes
h1toh4, and the dialog titles itselfh4:reproduce-issue-19105.webm
After - the same walk, same sizes, headings labelled
RcHeading, no level skipped:fixed-issue-19105.webm
Every replaced heading, master vs branch - 45 of 45 pixel-identical:
Checklist
Admin,Standard UserandUser Base