Conversation
This change creates the Triton Monolithic Repository TEP. Signed-off-by: J Wyman <jwyman@nvidia.com>
|
| The table below is the proposed structure for the monolithic repository. | ||
| Each path in the repository has a corresponding repository + path combination explaining where each folder and/or file is sourced from. |
There was a problem hiding this comment.
Migration Mapping Is Incomplete
The table is presented as the complete source-to-destination mapping, but following it would omit the tracked pyproject.toml and .clang-format files. It also references incorrect case-sensitive names: .CITATION.cff, Dockerfile.SDK, and five CmakeLists.txt destinations. On Linux, these names do not match the existing files, and CMake expects CMakeLists.txt. Implementing this mapping as written could therefore drop build, formatting, and metadata assets or produce component directories that CMake cannot build, contradicting REQ 01 and REQ 03. Please audit the mapping against every source repository and use each file's exact name.
| The merged repositories would be merged into a new `main` branch with a new base commit. | ||
| The existing `main` branch would be renamed to `legacy-main` and preserved in order to retain commit history. |
There was a problem hiding this comment.
Creating main from a new base and adding the repository contents as a snapshot does not make the original commits ancestors of the migrated files. Normal git log and git blame on the new default branch would stop at that snapshot, while the earlier history remains separate on legacy-main or in archived repositories. This defeats the proposal's stated history-preservation goal and loses normal per-line attribution on main. The proposal should require an ancestry-preserving import and define measurable history and attribution acceptance criteria rather than leaving an attribution script optional.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Create a Triton Enhancement Proposal to reduce the number of Triton repositories by merging the backend, common, core, and python_backend repositories into the server repository.
Preserving commit history by renaming server's
mainbranch tolegacy-mainand archiving the other repositories.The intent of this PR is to generate discussion around the topic and generate ideas for improving the developer workflow related to Triton Inference Server.