Fix Stripe verification failures caused by rounding crypto payments up - #899
Draft
ksn-stripe wants to merge 1 commit into
Draft
ksn-stripe wants to merge 1 commit into
ksn-stripe wants to merge 1 commit into
Conversation
…on failures Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fractional-cent crypto payments can fail Stripe transaction verification because the SDK rounds the PaymentIntent amount up. For example, a $0.015 payment creates a 2-cent PaymentIntent, but Stripe floors the on-chain amount to 1 cent and rejects the mismatch with
invalid_amount.Floor the amount to whole cents using integer division so it matches Stripe's comparison. The implementation changes two lines, with four boundary regression cases and a patch release note.
Validation: the $0.015 and $0.019999 regression cases failed before the fix. After the fix, the Stripe suite passed (116 tests; 7 integration tests skipped), along with lint, formatting, and TypeScript checks. No live payment was run.